-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Clean-up #56
Merged
🧹 Clean-up #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ri-heme
commented
Nov 17, 2022
- Close Remove number of samples from categorical shapes #39
- Close Clean-up config files #41
Latest version of `seaborn` requires palettes to be lists of colors, does not support NumPy array.
* 🎨 change docstrings to google convention * Update .gitignore with virtual environments and some files in docs/ folder * Initiate docs folder for ReadTheDocs with sphinx-quickstart * Update ReadTheDocs theme * Add pages to the ReadTheDocs * Update docstrings to dataloaders * ➕ 🔧 Add/configure Sphinx extensions * Remove TensorDataset from attributes * Remove docstrings from dunder methods * Add requirements.txt in docs/ and remove unneeded package from requirements * 🎨 In the docstrings remove types that are already defined in the functions * 🎨 Made docstring in under 80 characters per line * 🎨 Change docstring from N_patients to N_samples * Add docstrings to concat_con_list and concat_cat_list functions * 🎨 Update a docstring in concat_con_list function * ♻️ Change the categorical_shapes from (N_samples, N_variables, N_max-classes) to (N_variables, N_max-classes) and all following dependencies. * 📝 Update docstrings based on the functions changed * ♻️ Change variable name from processed_data_path to results_path * 📝 Add type hints to methods in vae.py module * ♻️ Change inversed logic statement to non inversed * ♻️ Rename the variable name that has the same name as builtin function Co-authored-by: Valentas <[email protected]> Co-authored-by: Ricardo Hernández Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.