Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up config files #41

Closed
4 tasks done
ri-heme opened this issue Oct 10, 2022 · 0 comments · Fixed by #56
Closed
4 tasks done

Clean-up config files #41

ri-heme opened this issue Oct 10, 2022 · 0 comments · Fixed by #56
Labels
refactoring Improve code structure or implementation without affecting functionality
Milestone
Make all modules ...

Comments

@ri-heme
Copy link
Collaborator

ri-heme commented Oct 10, 2022 •
edited
Loading

Moving to the task-based format introduced in #37, the configurations files need to be cleaned up:

  • Remove unused fields in move/conf/data/base_data (currently marked with # DEPRECATE).
  • Remove unused config groups: tuning_reconstruction, tuning_stability, training_latent, training_association *.
  • Remove any duplicate fields.
  • Remove any other unused fields (e.g., name in main).

* These will be re-implemented as configs of the task config group. (See #38 and #40)
@ri-heme ri-heme added the refactoring Improve code structure or implementation without affecting functionality label Oct 10, 2022
@ri-heme ri-heme added this to the Make all modules consistent milestone Oct 10, 2022
@ri-heme ri-heme linked a pull request Nov 15, 2022 that will close this issue
♻️ Refactor tune model #47
Merged
@ri-heme ri-heme removed a link to a pull request Nov 15, 2022
♻️ Refactor tune model #47
Merged
@ri-heme ri-heme mentioned this issue Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Improve code structure or implementation without affecting functionality
Projects
None yet
Milestone
Make all modules consistent
Development

Successfully merging a pull request may close this issue.

🧹 Clean-up RasmussenLab/MOVE
1 participant
@ri-heme