Add additional search engine, some fixes #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use log2 transformed ratios for plotting - use new ploty.express histogram
enryH
reviewed
Sep 26, 2023
| "Custom") | ||
|
|
||
| LOCAL_DEVELOPMENT = False | ||
| LOCAL_DEVELOPMENT = True |
There was a problem hiding this comment.
@scaramonche I guess you will have to decide about this change:)
RobbinBouwmeester
approved these changes
Sep 26, 2023
enryH
reviewed
Sep 26, 2023
Change back flag on local development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I stumbled across this - super cool project. I added support for the Sage search engine, since I happened to already have PXD028735 downloaded.
I've also added some misc. fixes - happy to cherrypick out any you don't want. Also, if you're not ready to add in additional tools, I can hold off on the PR.
Everything seems to work on all of the existing test datasets. I did notice that for some reason, the overall metrics are not being calculated correctly for Sage and displayed on the final scatterplot that compares tools (there are NaN values maybe?) despite the "Download calculated ratios" file looking OK.