_group_measurements in qubit sampling works with Prod, SProd, Sum, Hamiltonian #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5525 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 406 407 +1
Lines 37934 37728 -206
==========================================
- Hits 37810 37603 -207
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
lillian542
approved these changes
Apr 19, 2024
albi3ro
approved these changes
Apr 19, 2024
astralcai
added a commit
that referenced
this pull request
Apr 24, 2024
**Context:** PR #5525 led to two bugs: - `group_observables` uses `are_identity_pauli_words`, which does not work for legacy `Hamiltonian`. - `get_num_shots_and_executions` incorrectly counts number of executions for `Sum` **Description of the Change:** - Converts single-term `Hamiltonian` to `SProd` - Use the grouping information of `Sum` to correctly count number of executions. **Related Shortcut Issues:** [sc-61807] [sc-61812] Fixes #5561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The
_group_measurementsfunction inqubit/sampling.pygroups measurement processes with commuting observables together to reduce the number of executions. Now it does not handleProd,SProdor single-termHamiltonianandSum, which leads to inefficiencies with new opmath.Description of the Change:
Removes the branch that places
Prod,SProd,HamiltonianandSumin separate groups. Nowis_pauli_wordis used for everything.Benefits:
Better grouping leads to fewer number of executions.
Related GitHub Issues:
Fixes #5512
Related Shortcut Stories:
[sc-61306]