-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up bug fixes for _group_measurements
#5559
Conversation
Hello. You may have forgotten to update the changelog!
|
_group_measurements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5559 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 410 410
Lines 38235 37987 -248
==========================================
- Hits 38118 37869 -249
- Misses 117 118 +1 ☔ View full report in Codecov by Sentry. |
…o group-meas-bug
…o group-meas-bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems flawless to me!
Context:
PR #5525 led to two bugs:
group_observables
usesare_identity_pauli_words
, which does not work for legacyHamiltonian
.get_num_shots_and_executions
incorrectly counts number of executions forSum
Description of the Change:
Hamiltonian
toSProd
Sum
to correctly count number of executions.Related Shortcut Issues:
[sc-61807]
[sc-61812]
Fixes #5561