Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch-riscv: cherry-pick zcb support from upstream #252

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

eastonman
Copy link
Member

I also removed rv32 related code, since we do not have those APIs.

rogerchang23424 and others added 2 commits December 30, 2024 00:47
Added the following instructions:
c.lbu
c.lh
c.lhu
c.sb
c.sh
c.zext.b
c.sext.b
c.zext.h
c.sext.h
c.zext.w
c.not
c.mul

Reference: https://github.com/riscv/riscv-code-size-reduction
Change-Id: Ib04820bf5591b365a3bfbbd8b90655a8a1d844cf
@tastynoob
Copy link
Collaborator

Has it been tested on xs-gem5?

@eastonman
Copy link
Member Author

It works with new zcb checkpoint and NEMU with no obvious problem. Here's a comparison between DeterLoad-gcc1420-zcb-zicond-mimalloc and the checkpoint we used to use.

Screenshot 2025-01-02 at 15 09 30

@eastonman
Copy link
Member Author

eastonman commented Jan 2, 2025

Total ckpt amount is 610, and 609 passed difftest with NEMU. The one failed is related to some ssractch issue which I believe has nothing to do with Zcb.

@tastynoob tastynoob merged commit 75f1807 into xs-dev Jan 2, 2025
9 checks passed
@tastynoob
Copy link
Collaborator

Looks good

@seanwang2046
Copy link
Collaborator

significant performance boost got from the support of zicond-mimalloc support. very impressive finding!
we need to verify the performance gain on KMHV2 RTL design, as well as on KMHV3 GEM5 model; if it works, we need to change the benchmark checkpoint to GCC14 version, this will significantly help to achieve the goal of KMHV3.
excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants