-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bugs to run splash3 benchmarks #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinezyy
requested changes
Aug 27, 2024
tastynoob
reviewed
Aug 29, 2024
tastynoob
approved these changes
Aug 30, 2024
tastynoob
approved these changes
Aug 30, 2024
Change-Id: I701e91589364aa0f75b0f2a24ea571c090a4e5e3
Change-Id: Ie4a69cad2a3463ebb886c903a16e702258fdc545
Change-Id: Ib192e939288bae86eb25701541a28356c1794c72
Change-Id: I7fb105d4237463f4f9606ef489e04c5d4e6cb831
Change-Id: Iabc2aa5fdeaf46494bbab4aa6c485cdca0da50e4
1. Fix gem5 displaying too many red registers when diff fails 2. Do not print diff if diff succeeds when nemu runs another inst, unless using Diff flag Change-Id: I87dd9ec83693773882f9941326ecb021a517c229
1. Previously GEM5 waits for NEMU to execute one more inst (ecall), but if an intr follows ecall, diff fails, so we must diff ecall as well 2. Intrs changes privilege mode immediately, but frontend gets aware of it 13 cycles later. Therefore frontend might issue mem requests speculatively using vaddr but with address translation disabled, causing bus errors. Fixed by letting frontend stop fetching until new pc is sent to it. Change-Id: I7a7208b697535a72915ea55e8a975c4b22598437
-when vaddr !=0 && asid != 0 flush the pte that matches vaddr && asid Change-Id: Ib5a6a9e49d74827eb10edf9c352d2b1c7737655f
Change-Id: I2888e8653ca4e15cfecf2b714004450e22334d74
shinezyy
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.