Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New chyron color fields in projector #104

Merged

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom added the enhancement General enhancement which is neither bug nor feature label May 29, 2024
@luisa-beerboom luisa-beerboom added this to the 4.2 milestone May 29, 2024
Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, if the default is correct.

@@ -3874,10 +3874,18 @@ projector:
type: color
default: "#317796"
restriction_mode: A
chyron_background_color_2:
type: color
default: "#134768"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this default come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same colour as the global headbar in default theme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think it should be fine then. Nice.

Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -3874,10 +3874,18 @@ projector:
type: color
default: "#317796"
restriction_mode: A
chyron_background_color_2:
type: color
default: "#134768"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think it should be fine then. Nice.

@reiterl reiterl removed their assignment May 29, 2024
@Elblinator Elblinator merged commit 4d7c235 into OpenSlides:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants