-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New chyron color fields in projector #2451
New chyron color fields in projector #2451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there are failing tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment needs improvement.
|
||
class Migration(BaseModelMigration): | ||
""" | ||
This migration removes all remnants of the old structure level field in meeting users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay now.
* New chyron color fields in projector * Fix example data, add migration * Migration indices on example and initial data * Adress tests * Edit comment
* New chyron color fields in projector * Fix example data, add migration * Migration indices on example and initial data * Adress tests * Edit comment
Closes #2437
Needs OpenSlides/openslides-meta#104