Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New chyron color fields in projector #2451

Merged

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom added enhancement General enhancement which is neither bug nor feature los-extension labels May 29, 2024
@luisa-beerboom luisa-beerboom added this to the 4.2 milestone May 29, 2024
@luisa-beerboom luisa-beerboom added the migration Introduces a new migration label May 29, 2024
Copy link
Member

@r-peschke r-peschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are failing tests

Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment needs improvement.


class Migration(BaseModelMigration):
"""
This migration removes all remnants of the old structure level field in meeting users.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@reiterl reiterl assigned luisa-beerboom and unassigned reiterl May 30, 2024
Copy link
Member

@reiterl reiterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay now.

@Elblinator Elblinator added this pull request to the merge queue Jun 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2024
* New chyron color fields in projector

* Fix example data, add migration

* Migration indices on example and initial data

* Adress tests

* Edit comment
@Elblinator Elblinator removed this pull request from the merge queue due to a manual request Jun 4, 2024
@Elblinator Elblinator added this pull request to the merge queue Jun 4, 2024
Merged via the queue into OpenSlides:main with commit b1d707e Jun 4, 2024
5 checks passed
openslides-automation bot pushed a commit that referenced this pull request Jun 4, 2024
* New chyron color fields in projector

* Fix example data, add migration

* Migration indices on example and initial data

* Adress tests

* Edit comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature los-extension migration Introduces a new migration staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a new color setting for the projector
5 participants