-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: refacto stdcm op schedule #10192
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10192 +/- ##
==========================================
- Coverage 81.58% 81.53% -0.05%
==========================================
Files 1062 1062
Lines 104970 104874 -96
Branches 722 722
==========================================
- Hits 85636 85509 -127
- Misses 19293 19324 +31
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2c31a7d
to
b5f5574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. I have nothing to say about the code. I'm still testing the application's behavior.
Thanks for the refacto.
daac10b
to
b5f5574
Compare
b8af3cb
to
3a36df3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great refacto !
front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx
Outdated
Show resolved
Hide resolved
3a36df3
to
ccd7409
Compare
b6412be
to
4481c3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
d4ad536
to
bec74cc
Compare
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
…agement Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
bec74cc
to
dc8f701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work !
LGTM for e2e-tests
closes #10190
See commits