Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When spamming the different result tabs, the "run the simulation" button reappears #9624

Open
Castavo opened this issue Nov 7, 2024 · 3 comments
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug

Comments

@Castavo
Copy link
Contributor

Castavo commented Nov 7, 2024

What happened?

Enregistrement.de.l.ecran.2024-11-07.114310.mp4

When spamming the different result tabs, randomly the "run the simulation" button reappears (usually takes a few tens of fast clicks between tabs)

What did you expect to happen?

I expect the button to never reappear

How can we reproduce it (as minimally and precisely as possible)?

  1. Go to https://dev-osrd.reseau.sncf.fr/stdcm
  2. Make some simulations (I don't know how many you need exactly, at least two so you have tabs to switch between)
  3. Quickly click on the different tabs
  4. At some point the button should reappear

On which environments the bug occurs?

Dev (SNCF)

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

pr 9602 (merge of fam/fix-user-identity@1e971f6 into dev@bfa5205)

@Castavo Castavo added area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug labels Nov 7, 2024
@axrolld
Copy link
Contributor

axrolld commented Dec 6, 2024

I'm guessing this is linked to this bug. If the inputs don't change the form remains the same and the button never reappears.

Actually we might want to have the button always visible and clickable because it got some users very confused during the test. If they want to run he same simulation several times it's their loss imo. @thibautsailly what do you think ?

@thibautsailly
Copy link

It's our loss too, using computation capacity and server time for no benefit.
I think the confusion during the first half hour of usage is worth the lasting effect of having to be considerate when asking for a computation.
But I agree that the way it works now isn't ideal, and we can improve on it. We could display a message saying the form configuration is identical to a simulation below. And when we'll have requests history we'll need to adapt the message with the time elapsed since the simulation calculation.

@theocrsb
Copy link
Contributor

theocrsb commented Jan 8, 2025

Should be fixed by this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug
Projects
None yet
Development

No branches or pull requests

4 participants