Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manchette : hide a waypoint by clicking on it #8629

Open
7 of 9 tasks
SharglutDev opened this issue Aug 29, 2024 · 4 comments · Fixed by #9398 or OpenRailAssociation/osrd-ui#761 · May be fixed by #10233
Open
7 of 9 tasks

Manchette : hide a waypoint by clicking on it #8629

SharglutDev opened this issue Aug 29, 2024 · 4 comments · Fixed by #9398 or OpenRailAssociation/osrd-ui#761 · May be fixed by #10233
Assignees
Labels
area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management

Comments

@SharglutDev
Copy link
Contributor

SharglutDev commented Aug 29, 2024

Description and goal

In the manchette, we want to be able to hide a waypoint when clicking on it.

To work, this issue OpenRailAssociation/osrd-ui#399 needs be done first.

Acceptance criteria

  • When clicking on a waypoint, an options menu should be displayed
  • "Hide this waypoint" should be the only option visible for now
  • The menu's design should match the sketch one
  • Clicking on "Hide this waypoint" should close the menu and properly hide the waypoint
  • The space time chart should resize accordingly
  • The hidden waypoint should still be present in the waypoint list modal so it can't be displayed again
  • When the menu is open, clicking on another waypoint or the same one just closes the menu and we need one more click to open another one
  • When the menu is open, the scroll in the manchette, the manchette toolbar and pan in space time chart are disabled
  • If there was only two waypoints left, it shouldn't be possible to hide it (behavior needs to be checked with @thibautsailly)
@SharglutDev SharglutDev added area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management labels Aug 29, 2024
@SharglutDev SharglutDev self-assigned this Aug 29, 2024
@SharglutDev
Copy link
Contributor Author

SharglutDev commented Aug 29, 2024

@thibautsailly concerning the last AC, how should we proceed ?

  1. Disable the "Hide this waypoint" option
  2. Hide it
  3. Leave it normal but doesn't fire any action when clicking on it
  4. Leave it normal but displays a warning somewhere when clicking on it

@axrolld
Copy link
Contributor

axrolld commented Dec 12, 2024

Very very specific but because the options here are disabled, clicking on them do not close the window, it doesn nothing, but clikcing in the yellow zone works to close th window. Idk if it's easy to fix that, it's minor anyways.

Image

@thibautsailly
Copy link

The contextual menu item should be disabled with a title tag explaining that we need at least two OP to project the graph.
Later, we'll use a dedicated tooltip to display the message as soon as the user hovers the item, which will be very useful in other situations.

@thibautsailly
Copy link

thibautsailly commented Dec 12, 2024

Very very specific but because the options here are disabled, clicking on them do not close the window, it doesn nothing, but clikcing in the yellow zone works to close th window. Idk if it's easy to fix that, it's minor anyways.

We can discuss this, but to me it seems licking anywhere in the browser window should close this contextual menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
3 participants