ui-manchette/fix waypoint menu closing #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the click outside logic Signed-off-by: SharglutDev <[email protected]>
SharglutDev
changed the title
emersion
reviewed
Dec 13, 2024
ui-manchette-with-spacetimechart/src/stories/base-with-waypoint-menu.stories.tsx
Outdated
Show resolved
Hide resolved
|
Hm, not a fan of these "clicked outside" event handlers with ad-hoc checks. Would prefer a transparent div covering the whole document (with a portal). |
We need to discuss with @thibautsailly if having the waypoint menu displayed should block any first click interaction with the whole page (if yes we could maybe just use a modal ?) or just the manchette/spacetimechart area. |
|
Added the |
As some of the manchette action buttons can be disabled when the waypoint menu is displayed, the click event when clicking on them wasn't fired and the menu would'nt close. Update the style of the buttons to be able to click on the span inside the buttons which isn't disabled and update the story to listen to these click events in order to properly close the menu. Signed-off-by: SharglutDev <[email protected]>
Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
ui-manchette/fix-waypoint-menu-closing
branch
from
1e620a5 to
257a3c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits
close OpenRailAssociation/osrd#8629 (see last comments for the issue)