front: add waypoint menu in manchette #9398

SharglutDev · 2024-10-21T06:53:55Z

Mockup :
https://www.sketch.com/s/a26d84be-5fb2-41e4-9e84-96d90f46a997/a/OeJV9yG

codecov-commenter · 2024-10-21T06:56:11Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.56757% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (5a176ec) to head (3704e82).
Report is 7 commits behind head on dev.

Files with missing lines	Patch %	Lines
front/src/utils/hooks/useModalFocusTrap.ts	0.00%	11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##              dev    #9398    +/-   ##
========================================
  Coverage   80.03%   80.04%            
========================================
  Files        1049     1050     +1     
  Lines      105293   105423   +130     
  Branches      757      757            
========================================
+ Hits        84276    84390   +114     
- Misses      20976    20992    +16     
  Partials       41       41

Flag	Coverage Δ
editoast	`74.21% <ø> (-0.05%)`	⬇️
front	`89.25% <92.56%> (+0.01%)`	⬆️
gateway	`2.18% <ø> (ø)`
osrdyne	`3.28% <ø> (ø)`
railjson_generator	`87.50% <ø> (ø)`
tests	`87.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

emersion

Overall I'm not a huge fan of having the menu outside of ui-manchette. IMHO the positioning and styling of the menu belongs to osrd-ui.

I'm especially concerned about the positioning logic which is quite fragile: it hardcodes a lot of assumptions about the manchette, and desynchronizes when elements move around. Example bug: zoom in the manchette, open the menu, and then scroll. This is just one example, other interactions may break the menu alike.

front/src/common/OSRDMenu.tsx

...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx

front/src/modules/simulationResult/components/SpaceTimeChart/useWaypointMenu.tsx

emersion · 2024-10-22T15:35:19Z

Actually, maybe this coule be used instead?

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_anchor_positioning/Using

SharglutDev · 2024-10-23T08:21:58Z

Overall I'm not a huge fan of having the menu outside of ui-manchette. IMHO the positioning and styling of the menu belongs to osrd-ui.

I'm especially concerned about the positioning logic which is quite fragile: it hardcodes a lot of assumptions about the manchette, and desynchronizes when elements move around. Example bug: zoom in the manchette, open the menu, and then scroll. This is just one example, other interactions may break the menu alike.

You're totally right, I will check for solutions

Synar

LGTM beyond the positioning issue pointed out by emersion. But it is my understanding that https://github.com/OpenRailAssociation/osrd-ui/pull/668/files should solve this issue?

SharglutDev · 2024-10-28T08:27:17Z

LGTM beyond the positioning issue pointed out by emersion. But it is my understanding that https://github.com/OpenRailAssociation/osrd-ui/pull/668/files should solve this issue?

Yes exactly it's on wip :)

SharglutDev · 2024-11-28T11:11:29Z

Nothing new, just rebased with dev to be not too far behind with conflicts :)

- Change the listener to be on the document to be able to catch all events even if the focus was elsewhere - Add a parameter to set the focus on the first element of the modal/div if provided - Fix the focusTrap on the manchette menu Signed-off-by: SharglutDev <[email protected]>

theocrsb

LGTM and tested ! I just posted a little comment

front/src/styles/scss/common/components/_manchetteWithSpaceTimeChart.scss

...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx

clarani

LGTM ✅

Signed-off-by: SharglutDev <[email protected]>

- When clicking on a waypoint in the manchette, display a menu with some actions - Only action for now is to hide the waypoint in the manchette Signed-off-by: SharglutDev <[email protected]>

SharglutDev changed the title ~~Pfn/front/add waypoint menu~~ front: add waypoint menu in manchette Oct 21, 2024

SharglutDev force-pushed the pfn/front/add-waypoint-menu branch 3 times, most recently from accef67 to 589c8f7 Compare October 22, 2024 06:07

SharglutDev requested review from emersion and SarahBellaha October 22, 2024 07:36

SharglutDev marked this pull request as ready for review October 22, 2024 07:36

SharglutDev requested a review from a team as a code owner October 22, 2024 07:36

SharglutDev requested a review from Synar October 22, 2024 14:20

emersion reviewed Oct 22, 2024

View reviewed changes

SharglutDev force-pushed the pfn/front/add-waypoint-menu branch from bd08fca to 93ccaa9 Compare October 24, 2024 06:48

Synar reviewed Oct 27, 2024

View reviewed changes

SharglutDev force-pushed the pfn/front/add-waypoint-menu branch from 93ccaa9 to f2325dd Compare November 28, 2024 11:10

github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 28, 2024

SharglutDev force-pushed the pfn/front/add-waypoint-menu branch 2 times, most recently from 8cdbe23 to bdc093f Compare December 6, 2024 17:11

SharglutDev requested review from emersion and theocrsb December 10, 2024 17:58

SharglutDev force-pushed the pfn/front/add-waypoint-menu branch from fba2b87 to 19967ca Compare December 10, 2024 18:02

SharglutDev force-pushed the pfn/front/add-waypoint-menu branch from 19967ca to 4f87f08 Compare December 12, 2024 07:27

theocrsb approved these changes Dec 12, 2024

View reviewed changes

front/src/styles/scss/common/components/_manchetteWithSpaceTimeChart.scss Outdated Show resolved Hide resolved

clarani reviewed Dec 12, 2024

View reviewed changes

...ules/simulationResult/components/ManchetteWithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx Outdated Show resolved Hide resolved

clarani approved these changes Dec 12, 2024

View reviewed changes

front: add disabled style to osrd menu items

84fddc6

Signed-off-by: SharglutDev <[email protected]>

front: add waypoint menu in manchette

3704e82

- When clicking on a waypoint in the manchette, display a menu with some actions - Only action for now is to hide the waypoint in the manchette Signed-off-by: SharglutDev <[email protected]>

SharglutDev force-pushed the pfn/front/add-waypoint-menu branch from 344170d to 3704e82 Compare December 12, 2024 10:00

SharglutDev enabled auto-merge December 12, 2024 10:09

SharglutDev added this pull request to the merge queue Dec 12, 2024

Merged via the queue into dev with commit 18d57fa Dec 12, 2024
27 checks passed

SharglutDev deleted the pfn/front/add-waypoint-menu branch December 12, 2024 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

front: add waypoint menu in manchette #9398

front: add waypoint menu in manchette #9398

SharglutDev commented Oct 21, 2024 •

edited

Loading

codecov-commenter commented Oct 21, 2024 •

edited

Loading

emersion left a comment

emersion commented Oct 22, 2024

SharglutDev commented Oct 23, 2024 •

edited

Loading

Synar left a comment

SharglutDev commented Oct 28, 2024

SharglutDev commented Nov 28, 2024

theocrsb left a comment

clarani left a comment

front: add waypoint menu in manchette #9398

front: add waypoint menu in manchette #9398

Conversation

SharglutDev commented Oct 21, 2024 • edited Loading

codecov-commenter commented Oct 21, 2024 • edited Loading

Codecov Report

emersion left a comment

Choose a reason for hiding this comment

emersion commented Oct 22, 2024

SharglutDev commented Oct 23, 2024 • edited Loading

Synar left a comment

Choose a reason for hiding this comment

SharglutDev commented Oct 28, 2024

SharglutDev commented Nov 28, 2024

theocrsb left a comment

Choose a reason for hiding this comment

clarani left a comment

Choose a reason for hiding this comment

SharglutDev commented Oct 21, 2024 •

edited

Loading

codecov-commenter commented Oct 21, 2024 •

edited

Loading

SharglutDev commented Oct 23, 2024 •

edited

Loading