active_op_id needs to be shared

[ReimarBauer]

store widget data corresponding to docks

Purpose of PR?:

Fixes #2322
including tests

[matrss]

In which situation should the topview's active_op_id be something different than the mainwindow.mscolab.active_op_id? I.e. why does the topview need a copy of this attribute, instead of always using the one from the mainwindow?

[ReimarBauer]

topview won't need it. The current implementation of the multiple_flighpath_dockingwidget has no access to the mainwindow, e.g.
https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/multiple_flightpath_dockwidget.py#L507
There were more vars introduced which are already known in the mainwindow https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/topview.py#L204

Currently I do prefer first a kind of logic test coverage before we refactor the inner. It is somehow improving the Proof-Of-Concept before we can do the cleanup.

One of the bigger refactoring steps is to remove all the dups and focus on a better understandable API.

[matrss]

Couldn't the topview just hold a reference to the mainwindow then? Holding another reference to all of the mainwindow's signals is also something that feels wrong to me, and could be eliminated if the mainwindow was just accessible through the topview.

[ReimarBauer]

I think that would be a better solution and has to be done in a refactoring. @Jatin2020-24 did you have a reason not to do it that way?

This PR is related to fix a bug in the order for opening the dockingwidget when a mscolab operation was selected. We need a few more tests to figure that any combination for the docking widget works.

I guess there is at least one more bug which needs to be test covered and fixed.

When this part is refactored we also have to refactor tests.

[ReimarBauer]

@matrss something more missing or should be improved?

[matrss]

I still think we shouldn't duplicate this attribute everywhere. What is wrong with exposing a reference to the mainwindow on the topview? Then it would be possible for the MultipleFlightpathControlWidget to just access self.ui.mainwindow.active_op_id, or something like that.

[matrss]

Alternatively, make the topview's active_op_id a getter/@property for the one from the mainwindow so that it can never be out of sync. Depends on how much of the mainwindow we want to have accessible everywhere.

[matrss]

@ReimarBauer and I talked about this a bit this morning and we came to the conclusion that the PR should be merged as-is, but we need to take a look at things like this in the future and make an effort to refactor these things and clean up some of it.