Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review and refactor usage of lamba in QObject connect #2320

Open
ReimarBauer opened this issue Apr 15, 2024 · 4 comments
Open

review and refactor usage of lamba in QObject connect #2320

ReimarBauer opened this issue Apr 15, 2024 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@ReimarBauer
Copy link
Member

ReimarBauer commented Apr 15, 2024

On some of the QObjects we use connect with a lambda function.
This is likly not correct and needs to be verified. It surpresses the capabilty of QT to check if a slot exists.
Test coverage should become checked too.

Prefered solution without lambda.

Also a lot of these signals are duplicated. Likly that is not needed when the mainwindow gets referenced in the multiple_flightpath docking widget.

@ReimarBauer ReimarBauer added the enhancement New feature or request label Apr 15, 2024
@ReimarBauer ReimarBauer added this to the 10.0.0 milestone Apr 15, 2024
@rohit2p
Copy link
Contributor

rohit2p commented Apr 18, 2024

can i work on this @ReimarBauer

@ReimarBauer
Copy link
Member Author

You can but it is likly a larger refactoring and the tests are not completed yet, see #2326 (comment)

@rohit2p
Copy link
Contributor

rohit2p commented Apr 18, 2024

Okey

@ReimarBauer
Copy link
Member Author

Start with referencing the mainwindow in the other components then remove duplicated code parts. Some hints are in the linked PR.

@ReimarBauer ReimarBauer modified the milestones: 10.0.0, 9.0.0 Apr 19, 2024
@ReimarBauer ReimarBauer modified the milestones: 9.0.0, 10.0.0 May 16, 2024
@rohit2p rohit2p removed their assignment Oct 18, 2024
@ReimarBauer ReimarBauer modified the milestones: 10.0.0, 11.0.0 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants