Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding dark mode. #14

Closed
3 tasks done
msv6264 opened this issue Dec 31, 2024 · 13 comments · Fixed by #84
Closed
3 tasks done

Feat: Adding dark mode. #14

msv6264 opened this issue Dec 31, 2024 · 13 comments · Fixed by #84
Assignees

Comments

@msv6264
Copy link
Contributor

msv6264 commented Dec 31, 2024

Describe the feature

Many programmers or users prefer dark mode which is comfort for their eyes and looks attractive, I want to add dark mode to the website.

Add ScreenShots

Screenshot 2024-12-31 193132

Record

  • I agree to follow this project's Contributing.md
  • I'm a SWOC contributor
  • I want to work on this issue
Copy link

Thank you for creating this issue! 🎉 @Ojas-Arora will look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTE.md for guidelines on contributing to this project.

@Ojas-Arora
Copy link
Owner

@msv6264 Issue assigned to you.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 3, 2025

@Ojas-Arora I just noticed that the issue got merged but the i haven't created pr the toggle button is created by someone else and I am trying to make it work, can you please kindly look into this and I have another doubt regarding enabling dark mode, I've implemented dark mode for the home page, but I noticed that the toggle button isn't present on the remaining pages. Should I proceed to add the toggle button and implement dark mode functionality for those pages as well, or is there a specific plan or approach you'd prefer I follow?
the below picture is implementation of dark theme in home page
Screenshot 2025-01-03 233840

@Ojas-Arora
Copy link
Owner

@msv6264 You can see I have made a issue #28 Firstly u can do that so that Same Navbar is made in every page of the website and Dark Mode is enabled in every page and the Toggle Theme in the Photo is good so do so in all the required pages but firstly u can resolve #28 then can do this.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 3, 2025

ok, I will do that and if I do #28 and #14 in one branch and create one pr, is it ok?

@Ojas-Arora
Copy link
Owner

@msv6264 No , Create different Prs for both with different Branch Names.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 3, 2025

ok

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 3, 2025

Then, can you please assign #28 to me

@Ojas-Arora
Copy link
Owner

@msv6264 Just message in the Issue by Tagging me. I will assign to You.

@Ojas-Arora
Copy link
Owner

@msv6264 Your Points have been added in the Leaderboard. If any issue can ask me.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 8, 2025

@Ojas-Arora Ok Thank you, as for other issue of converting into dark mode, I will complete it by tomorrow

@Ojas-Arora
Copy link
Owner

@msv6264 No issue , Take your Time.

Copy link

Hello @msv6264! 🎉

Your issue #14 - Feat: Adding dark mode. has been successfully closed.

We appreciate your valuable contribution and your help in improving the project. If you have any more ideas, questions, or issues, feel free to open a new issue or join the discussion in our community forum.

Stay awesome! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants