Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing dark mode #84

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Conversation

msv6264
Copy link
Contributor

@msv6264 msv6264 commented Jan 10, 2025

Related Issue

Fixes #14

Description

Added dark mode in all pages of website

Type of PR

  • Bug fix
  • [✅] Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot 2025-01-10 204535
Screenshot 2025-01-10 204553
Screenshot 2025-01-10 204605
Screenshot 2025-01-10 204615
Screenshot 2025-01-10 204630
Screenshot 2025-01-10 204645

Checklist:

  • [✅] I have performed a self-review of my code
  • [✅] I have read and followed the Contribution Guidelines.
  • [✅] I have tested the changes thoroughly before submitting this pull request.
  • [✅] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [✅] I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scd-profile-score ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 5:30pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Ojas-Arora
Copy link
Owner

@msv6264 In your Deployment There are changes in the color code of the Main Page, About Page and some more. See the original Website color code and change those . Color Code for Dark Mode is alright no need to change that. Rest all is Correct.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 10, 2025

@Ojas-Arora sorry, I will change that

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 11, 2025

Hello @Ojas-Arora I have made changes please review it. By the way there is no option to go back from the register or login page in the original website as well, as of now I just dark mode, if you want to me to fix it, please let me know.

@Ojas-Arora
Copy link
Owner

Ojas-Arora commented Jan 11, 2025

@msv6264 The color code issue has been not resolved even now as told above and also 2 subscribe buttons in the navbar. Ya If u want to work on the back issue in register/login page u can make a new issue for that.

@Ojas-Arora
Copy link
Owner

@msv6264 color has been changed right but now the Register Page has been changed. Check that.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 11, 2025

@Ojas-Arora Now can you please check

Copy link
Owner

@Ojas-Arora Ojas-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@Ojas-Arora Ojas-Arora merged commit 391399b into Ojas-Arora:main Jan 11, 2025
2 checks passed
@msv6264 msv6264 deleted the implementing-dark-mode branch January 11, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Adding dark mode.
2 participants