Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch for first pr #23

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

msv6264
Copy link
Contributor

@msv6264 msv6264 commented Jan 2, 2025

Related Issue

Fixes #6

Description

I have added hamburger menu which makes the website responsive even for smaller screen sizes.

Type of PR

  • [✅ ] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

img

Checklist:

  • [✅ ] I have performed a self-review of my code
  • [✅ ] I have read and followed the Contribution Guidelines.
  • [ ✅ ] I have tested the changes thoroughly before submitting this pull request.
  • [✅ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ ✅ ] I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scd-profile-score ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:13pm

Copy link

github-actions bot commented Jan 2, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 2, 2025

As per your instructions, I have created a new branch instead of using the main branch. Apologies for any inconvenience caused.

@Ojas-Arora
Copy link
Owner

@msv6264 Do Branch Updation.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 2, 2025

I have updated my branch with the latest changes from the main branch, and after verifying, I can confirm that everything is up-to-date and there are no changes or conflicts.

@Ojas-Arora
Copy link
Owner

@msv6264 I think u have not pushed the changes after the Branch Updation as I am not able to see the new Deployment after the Branch Updation. Check this.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 2, 2025

I apologize for any inconvenience caused earlier. Since I'm still familiarizing myself with GitHub, I encountered some challenges. I understand the issue now and would like to create a new branch from the main branch, apply the changes I’ve made, and submit a new pull request with these updates.

Copy link
Owner

@Ojas-Arora Ojas-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work

@Ojas-Arora Ojas-Arora merged commit a6fa24b into Ojas-Arora:main Jan 2, 2025
2 checks passed
@Ojas-Arora
Copy link
Owner

@msv6264 No worries at all! It's great that you’ve understood the issue.

@Ojas-Arora
Copy link
Owner

@msv6264 Similarly make a new Pr for your remaining Pull Requests as Draft with a new Branch so that They can also be merged.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 2, 2025

Ok thank you very much for your kindness I will definitely do that as soon as possible

@msv6264 msv6264 deleted the new-branch-for-first-pr branch January 3, 2025 13:56
@msv6264
Copy link
Contributor Author

msv6264 commented Jan 3, 2025

@Ojas-Arora The issues I raised and created draft pr's are already resolved in the original website, can i delete the draft pr's?

@Ojas-Arora
Copy link
Owner

Ojas-Arora commented Jan 3, 2025

@msv6264 Your two issues made website Responsive and adding Hover on Logo has been added in the original Website but the issue but your two issues #14 and #15 are left now. You can delete the draft for adding Hover on Logo but for the pr fix/remove begin your journey #15 I will merge it so make sure to remove the draft and update the branch so that I will merge it.

@Ojas-Arora Ojas-Arora added the done label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants