-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New branch for first pr #23
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
As per your instructions, I have created a new branch instead of using the main branch. Apologies for any inconvenience caused. |
@msv6264 Do Branch Updation. |
I have updated my branch with the latest changes from the main branch, and after verifying, I can confirm that everything is up-to-date and there are no changes or conflicts. |
@msv6264 I think u have not pushed the changes after the Branch Updation as I am not able to see the new Deployment after the Branch Updation. Check this. |
I apologize for any inconvenience caused earlier. Since I'm still familiarizing myself with GitHub, I encountered some challenges. I understand the issue now and would like to create a new branch from the main branch, apply the changes I’ve made, and submit a new pull request with these updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work
@msv6264 No worries at all! It's great that you’ve understood the issue. |
@msv6264 Similarly make a new Pr for your remaining Pull Requests as Draft with a new Branch so that They can also be merged. |
Ok thank you very much for your kindness I will definitely do that as soon as possible |
@Ojas-Arora The issues I raised and created draft pr's are already resolved in the original website, can i delete the draft pr's? |
@msv6264 Your two issues made website Responsive and adding Hover on Logo has been added in the original Website but the issue but your two issues #14 and #15 are left now. You can delete the draft for adding Hover on Logo but for the pr fix/remove begin your journey #15 I will merge it so make sure to remove the draft and update the branch so that I will merge it. |
Related Issue
Fixes #6
Description
I have added hamburger menu which makes the website responsive even for smaller screen sizes.
Type of PR
Screenshots / videos (if applicable)
Checklist: