-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fuzzer.bash script and entrypoint in docker file #2102
Merged
Merged
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ec2541b
Fix nitro-fuzzer entrypoint argument
anodar 4445f93
Fix script to complain when neither build nor fuzzer name is specified
anodar 2e5832e
Add flag to fuzz script for timeout
anodar 601681a
Add workflow for release ci that is triggered with PR tag, run nitro …
anodar 86cf5ca
Trigger workflow from label instead of PR title
anodar 32ea163
Update workflow triggering conditions
anodar 991f055
Fix workflow syntax
anodar e71ca4b
Yet another attempt to fix workflow syntax
anodar ee8cc8d
Checout submodules recursively in the workflow, cache docker layers
anodar 14fb850
Ignore timeout error, and error out only if the fuzzing binary errors…
anodar c65ecb4
Merge branch 'master' into fix-fuzzer-entrypoint
anodar e8e1fb3
Merge branch 'fix-fuzzer-entrypoint' into release-testing
anodar e5757b8
Merge branch 'master' into fix-fuzzer-entrypoint
anodar 254de23
Revert running fuzzer in release-ci
anodar 444eae3
Merge branch 'release-testing' of github.com:OffchainLabs/nitro into …
anodar 208119b
Merge pull request #2103 from OffchainLabs/release-testing
anodar 2770f81
Merge branch 'master' into fix-fuzzer-entrypoint
anodar d08507c
Merge branch 'master' into fix-fuzzer-entrypoint
anodar 07c74c7
Change release workflow trigger condition
anodar 5969a11
Change trigger to workflow_dispatch only
anodar b127b8a
Merge branch 'master' into fix-fuzzer-entrypoint
anodar f4810cc
Merge branch 'master' into fix-fuzzer-entrypoint
joshuacolvin0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: Release CI | ||
run-name: Release CI triggered from @${{ github.actor }} of ${{ github.head_ref }} | ||
|
||
on: | ||
workflow_dispatch: | ||
merge_group: | ||
pull_request: | ||
push: | ||
branches: | ||
- master | ||
- develop | ||
jobs: | ||
build_and_run: | ||
runs-on: ubuntu-8 | ||
|
||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
with: | ||
submodules: recursive | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@v3 | ||
with: | ||
driver-opts: network=host | ||
|
||
- name: Cache Docker layers | ||
uses: actions/cache@v3 | ||
with: | ||
path: /tmp/.buildx-cache | ||
key: ${{ runner.os }}-buildx-${{ hashFiles('Dockerfile') }} | ||
restore-keys: ${{ runner.os }}-buildx- | ||
|
||
|
||
- name: Check PR Label For Release label | ||
if: ${{ !contains(github.event.*.labels.*.name, 'release') }} | ||
run: | | ||
echo "Not a release candidate. Skipping workflow." | ||
exit 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make since to use
instead? That way you don't need to check for release label either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to that.
My reasoning behind having label that triggers it was for the case where one makes big changes and wants to run more exhaustive testing without creating a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you said actually makes more sense rather than triggering on actual release. What do you think about just having it trigger on
workflow_dispatch
for now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG, changed to that.