Fix fuzzer.bash script and entrypoint in docker file #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Create Release CI workflow, implement timeout in fuzzing script and add it to release ci workflow
.github/workflows/release-ci.yml
Outdated
| workflow_dispatch: | ||
| merge_group: | ||
| pull_request: | ||
| push: |
There was a problem hiding this comment.
Would it make since to use
on:
release:
types: [created, published]
instead? That way you don't need to check for release label either.
There was a problem hiding this comment.
Changed to that.
My reasoning behind having label that triggers it was for the case where one makes big changes and wants to run more exhaustive testing without creating a release.
There was a problem hiding this comment.
What you said actually makes more sense rather than triggering on actual release. What do you think about just having it trigger on workflow_dispatch for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running the nitro-fuzzer docker doesn't do anything, it silently fails without error code or a log.