Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make not require linux for socketcan #93

Open
wants to merge 2 commits into
base: Develop
Choose a base branch
from

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Dec 30, 2024

Changes

  • Fixups docker by adding dockerignore to save space and fixing ci syntax
  • CI rust --all to pickup the macro crates
  • Remove old protobuf stuff from readme
  • Make socketcan an optional dependency

Notes

I originally tried to reorganize the repository for no reason, hence the feature/remove-linux-depends2. I did not propose it because 1. it didnt work well and 2. it was unecessarily complicated.

Test Cases

  • Windows users can cargo run --bin simulate. I need someone to do this lol my Windows doesnt have enough space for rust.

To Do

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #71

@jr1221 jr1221 requested a review from harrison-e January 7, 2025 17:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome

Copy link
Contributor

@harrison-e harrison-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants