vulkan-hdr-layer-kwin6: init at 0-unstable-2024-10-19 #345805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
8.has: package (new)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4632 |
FliegendeWurst
requested changes
Nov 2, 2024
|
Would be good to squash the commits |
d4rk
force-pushed
the
vulkan-hdr-layer
branch
from
fdaf513 to
f04063d
Compare
d4rk
force-pushed
the
vulkan-hdr-layer
branch
from
f04063d to
ae237fb
Compare
Done! |
d4rk
force-pushed
the
vulkan-hdr-layer
branch
from
ae237fb to
1b73ef5
Compare
d4rk
force-pushed
the
vulkan-hdr-layer
branch
3 times, most recently
from
4c9e24b to
4224ee0
Compare
d4rk
changed the title
FliegendeWurst
requested changes
Nov 5, 2024
https://github.com/Zamundaaa/VK_hdr_layer Enables HDR support for Vulkan clients (such as mpv) on kwin6. This is likely to be a temporary solution until Wayland upstream adopts the necessary protocols, however that has been in the works for many years: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/14 For the time being, this provides a path for users to experiment with HDR, share feedback and hopefully make progress. Arch provides a similar package: https://aur.archlinux.org/packages/vk-hdr-layer-kwin6-git
d4rk
force-pushed
the
vulkan-hdr-layer
branch
from
996da2a to
f28124f
Compare
FliegendeWurst
approved these changes
Nov 13, 2024
FliegendeWurst
added
the
12.approvals: 1
|
Thanks for the review @FliegendeWurst! Just wondering if this is ready to be merged and if so, when that might happen. |
|
In my opinion it is ready. All that's left is that someone with permission merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables HDR support for Vulkan clients (such as
mpv) on kwin6.https://github.com/Zamundaaa/VK_hdr_layer
This is likely to be a temporary solution until Wayland upstream adopts the necessary protocols, however that has been in the works for many years.
For the time being, this provides a path for users to experiment with HDR, share feedback and hopefully make progress.
Arch provides a similar package:
https://aur.archlinux.org/packages/vk-hdr-layer-kwin6-git
Example usage after installing the layer:
To enable Vulkan loader logs:
PS: The latest version of
gamescopedoesn't need Vulkan for HDR.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.