Add support for backing up Aviti runs to PDC #442
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
| ) | ||
| or ( | ||
| self._get_run_type(run.name) == "aviti" | ||
| and os.path.exists(os.path.join(run_path, "RunUploaded.json")) |
There was a problem hiding this comment.
So this will start archiving as soon as sequencing has finished? I guess that's what we want
There was a problem hiding this comment.
Well, the run should be in nosync, which is once it's been demuxed and transferred to miarka. The only catch is that if we need to redemux, we have to wait for the archiving to finish.
|
Note that you have one file that fails Ruff formatting in case you would like to fix that before merging. |
Spaaace 😄 |
|
Haha, yes that was some major reformating. |
| @@ -179,10 +196,12 @@ def _get_run_type(self, run): | |||
| "^(\d{8})_(\d{4})_([1-3][A-H])_([0-9a-zA-Z]+)_([0-9a-zA-Z]+)$", run | |||
| ): | |||
| run_type = "promethion" | |||
| elif "_AV" in run: | |||
There was a problem hiding this comment.
Is there a reason we can't use filesystem.RUN_RE_ELEMENT for this too? I see that the RUN_RE_ONT is slightly different
| ) | ||
| except: | ||
| logger.warn(f'Not able to log "pdc_archived" timestamp for run {run}') | ||
| if "_AV" not in run: |
No description provided.