-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSD-1646: Updating NewsletterSignUp, Radio, RadioGroup, and Searchbar to Chakra 2.8 theme API #1480
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1d066fe
Radio done
7emansell 336c8d3
Fixing type
7emansell 11b007f
Radio group done . Maybe
7emansell ffdd419
Newsletter signup done
7emansell 3cffca2
Search bar
7emansell 75e0de2
Locking package versions
7emansell 7b25898
Without esbuild
7emansell 3fabaa3
Merge remote-tracking branch 'origin/react18-and-chakra' into DSD-164…
7emansell fe0209b
Fixing merge
7emansell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/** This data is used to populate the ComponentChangelogTable component. | ||
* | ||
* date: string (when adding new entry during development, set value as "Prerelease") | ||
* version: string (when adding new entry during development, set value as "Prerelease") | ||
* type: "Bug Fix" | "New Feature" | "Update"; | ||
* affects: array["Accessibility" | "Documentation" | "Functionality" | "Styles"]; | ||
* notes: array (will render as a bulleted list, add one array element for each list element) | ||
*/ | ||
import { ChangelogData } from "../../utils/ComponentChangelogTable"; | ||
|
||
export const changelogData: ChangelogData[] = [ | ||
{ | ||
date: "Prerelease", | ||
version: "Prerelease", | ||
type: "Update", | ||
affects: ["Styles"], | ||
notes: ["Chakra 2.8 update."], | ||
}, | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/** This data is used to populate the ComponentChangelogTable component. | ||
* | ||
* date: string (when adding new entry during development, set value as "Prerelease") | ||
* version: string (when adding new entry during development, set value as "Prerelease") | ||
* type: "Bug Fix" | "New Feature" | "Update"; | ||
* affects: array["Accessibility" | "Documentation" | "Functionality" | "Styles"]; | ||
* notes: array (will render as a bulleted list, add one array element for each list element) | ||
*/ | ||
import { ChangelogData } from "../../utils/ComponentChangelogTable"; | ||
|
||
export const changelogData: ChangelogData[] = [ | ||
{ | ||
date: "Prerelease", | ||
version: "Prerelease", | ||
type: "Update", | ||
affects: ["Styles"], | ||
notes: ["Chakra 2.8 update."], | ||
}, | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
/** | ||
* For usage in Storybook stories to set the default value of a boolean prop. | ||
*/ | ||
export const argsBooleanType = (defaultValue = false) => ({ | ||
control: { type: "boolean" }, | ||
table: { defaultValue: { summary: defaultValue } }, | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some esbuild issues as well. Can you try running this without
esbuild
? If we can remove this dependency, that'd be great, otherwise it's okay to keep.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's running fine without
esbuild
now so I removed it.. weird though