-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSD-1646: Updating NewsletterSignUp, Radio, RadioGroup, and Searchbar to Chakra 2.8 theme API #1480
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your pull request is missing a changelog—was that intentional? |
Noting that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me pending updates to the Heading
and Button
components which will be updated in other PRs. I think that's also what's happening in SearchBar
where the TextInput
component needs an update but that's a separate PR, so it makes sense that it's not full width just yet.
package.json
Outdated
"@chakra-ui/react": "2.8.1", | ||
"@chakra-ui/system": "2.6.2", | ||
"@chakra-ui/focus-lock": ">=2.1.0", | ||
"@chakra-ui/react": ">=2.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you make all the ">=" updates? Did you encounter any issues while installing packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops yes accidentally, I had something up with esbuild, they're locked now
package.json
Outdated
@@ -60,6 +60,7 @@ | |||
"@emotion/react": "11.11.1", | |||
"@emotion/styled": "11.11.0", | |||
"downshift": "6.1.7", | |||
"esbuild": "^0.19.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some esbuild issues as well. Can you try running this without esbuild
? If we can remove this dependency, that'd be great, otherwise it's okay to keep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's running fine without esbuild
now so I removed it.. weird though
Fixes JIRA ticket DSD-1646
This PR does the following:
NewsletterSignUp
,Radio
,RadioGroup
, andSearchbar
components to use the Chakra 2.8 updated API for their theme object.How has this been tested?
Locally and compared against the production Storybook instance.
Accessibility concerns or updates
N/A
Checklist:
Front End Review: