Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFR-2430: Set flags based on limited access permissions #494
SFR-2430: Set flags based on limited access permissions #494
Changes from 17 commits
4075859
725dbe8
bc8ed67
1e7c7f1
e6547a9
ec9ef1f
f84ec29
ccbc0a3
7075c1b
4b03d86
8f1345f
985bacf
785db74
bf46f63
0c914a7
fed93cd
bf3a191
63e8dcd
7e73baa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming but do we want have a default value here and does it make sense for it to be True? Seems like in all cases this function will be called with that param set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove the default here - I wanted to consistently fall back to the least permissive option to reduce the likelihood of something being set to open-access because of malformed input data, but I agree that this is not such a case.