SFR-2430: Set flags based on limited access permissions #494
Conversation
Use entire project name instead of first word and build buckets from project name instead of publisher name
|
@Apophenia is this ready for review? |
|
Do we need to change the has_part flags for the manifest as well based on the parsed permissions? |
I'll check the original Michigan ingest process, but I don't think so. We discussed different approaches, but I believe the way it was implemented was that all manifests are stored in the public bucket, and the manifests contain fulfill links, but those fulfillment links are what require authentication (and they're stored in the private buckets). |
|
|
||
| def store_pdf_manifest(self, record: Record): | ||
| def store_pdf_manifest(self, record: Record, requires_login: bool=True): |
There was a problem hiding this comment.
Just confirming but do we want have a default value here and does it make sense for it to be True? Seems like in all cases this function will be called with that param set.
There was a problem hiding this comment.
I'll remove the default here - I wanted to consistently fall back to the least permissive option to reduce the likelihood of something being set to open-access because of malformed input data, but I agree that this is not such a case.
…pipeline into limited-access-permissions
Still lacking full testing for the flag logic but ready for re-review!