-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UpdatingCLIAzureMLNIMDeployment_for_demo #99
base: main
Are you sure you want to change the base?
Changes from all commits
5a55209
e263063
ae5d76a
2ef9fd4
6b390b9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ name: deployment_name_placeholder | |
endpoint_name: endpoint_name_placeholder | ||
environment: | ||
name: image_name_placeholder-env | ||
image: acr_registry_placeholder.azurecr.io/image_name_placeholder:v1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you remove "latest" and mention "tag" instead to make it generalized. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When using the v1 it was crashing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried the way it was and the deployment was throwing errors as it couldn't find the image, the errors went away with latest |
||
image: acr_registry_placeholder.azurecr.io/image_name_placeholder:latest | ||
inference_config: | ||
liveness_route: | ||
path: /v1/health/ready | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the create resource group flag? I think it is safe to assume that users will already have a resource group to deploy this on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually dont think it is safe.
Its a bit redundant but it makes the script to work even when the user does not have a work group for the workspace
I for instance like to create a worksgroup for every single project/test I do as it is way easier to delete resources by workgroup than individually