UpdatingCLIAzureMLNIMDeployment_for_demo #99
Conversation
…ixing sed commands and container label
| @@ -3,7 +3,7 @@ name: deployment_name_placeholder | |||
| endpoint_name: endpoint_name_placeholder | |||
| environment: | |||
| name: image_name_placeholder-env | |||
| image: acr_registry_placeholder.azurecr.io/image_name_placeholder:v1 | |||
There was a problem hiding this comment.
Can you remove "latest" and mention "tag" instead to make it generalized.
There was a problem hiding this comment.
When using the v1 it was crashing
There was a problem hiding this comment.
I tried the way it was and the deployment was throwing errors as it couldn't find the image, the errors went away with latest
| CREATE_WORKSPACE=false | ||
|
|
||
| for i in "$@"; do | ||
| case $i in | ||
| --create_new_workspace) CREATE_WORKSPACE=true ;; | ||
| -*|--*) echo "Unknown option $i"; exit 1 ;; | ||
| --create_new_resource_group) |
There was a problem hiding this comment.
Can you remove the create resource group flag? I think it is safe to assume that users will already have a resource group to deploy this on.
There was a problem hiding this comment.
I actually dont think it is safe.
Its a bit redundant but it makes the script to work even when the user does not have a work group for the workspace
I for instance like to create a worksgroup for every single project/test I do as it is way easier to delete resources by workgroup than individually
No description provided.