Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OQC client upgrade #2352

Merged
merged 15 commits into from
Nov 15, 2024
Merged

OQC client upgrade #2352

merged 15 commits into from
Nov 15, 2024

Conversation

jfriel-oqc
Copy link
Contributor

Code changes for the latest version of the OQC client to stay aligned with API changes.

Tests updated and tested locally.

Following with doc changes, just getting the code up now.

Copy link

copy-pr-bot bot commented Nov 4, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 4, 2024

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 12, 2024

/ok to test

Command Bot: Processing...

Signed-off-by: Noriyuki Kushida <[email protected]>

DCO Remediation Commit for Noriyuki Kushida <[email protected]>

I, Noriyuki Kushida <[email protected]>, hereby add my Signed-off-by to this commit: d019f7e
I, Noriyuki Kushida <[email protected]>, hereby add my Signed-off-by to this commit: f26f908
I, Noriyuki Kushida <[email protected]>, hereby add my Signed-off-by to this commit: 88734a5

Signed-off-by: Noriyuki Kushida <[email protected]>

DCO Remediation Commit for root <[email protected]>

I, root <[email protected]>, hereby add my Signed-off-by to this commit: b453c84

Signed-off-by: root <[email protected]>
I, root <[email protected]>, hereby add my Signed-off-by to this commit: b453c84

Signed-off-by: root <[email protected]>

Signed-off-by: root <[email protected]>
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 13, 2024

/ok to test

Command Bot: Processing...

Signed-off-by: Noriyuki Kushida <[email protected]>
@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 13, 2024

/ok to test

Command Bot: Processing...

@bettinaheim
Copy link
Collaborator

bettinaheim commented Nov 14, 2024

/ok to test

Command Bot: Processing...

@bmhowe23
Copy link
Collaborator

bmhowe23 commented Nov 14, 2024

/ok to test

Command Bot: Processing...

Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes LGTM. Thank you, @jfriel-oqc and @nkushida-oqc!

@bmhowe23 bmhowe23 enabled auto-merge (squash) November 15, 2024 00:37
@bmhowe23 bmhowe23 merged commit 3300b12 into NVIDIA:main Nov 15, 2024
219 of 223 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants