Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tapering of atm ens perts at the model top #3097

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Enable tapering of atm ens perts at the model top #3097

merged 5 commits into from
Nov 15, 2024

Conversation

CatherineThomas-NOAA
Copy link
Contributor

Description

This commit turns on the tapering of atmospheric ensemble perturbations at the model top in the EnKF to reduce the upper layer ensemble spread. This commit also includes a minor update of changing the IC tag date for the staged HR4 ICs.

Resolves #3096

Type of change

  • [ x ] New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

C384/C192 ATM-only cycled tests on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@CatherineThomas-NOAA
Enable tapering of atm ens perts at the model top
73d8f20 
This commit turns on the tapering of atmospheric
ensemble perturbations at the model top in the
EnKF to reduce the upper layer ensemble spread.
This commit also includes a minor update of
changing the IC tag date for the staged HR4 ICs.

Resolves NOAA-EMC#3096
RussTreadon-NOAA
RussTreadon-NOAA reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR require / would it benefit from an update to any of the gsi_*fd hashes in sorc/?

@CatherineThomas-NOAA
Copy link
Contributor Author

@RussTreadon-NOAA: No, the needed changes were merged into the GSI quite a while ago and the current g-w hash has what's needed. I will, however, be opening a PR to update the GSI enkf regression test to include this parameter change.

@RussTreadon-NOAA
Copy link
Contributor

@CatherineThomas-NOAA , good catch regarding the GSI enkf ctest. We don't want to miss this option there!

RussTreadon-NOAA
RussTreadon-NOAA previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not run a cycled test to confirm the changes work as intended. @CatherineThomas-NOAA tested via a C384/C192 ATM-only cycled parallel on Hera. This works for me.

Approve.

@CatherineThomas-NOAA CatherineThomas-NOAA mentioned this pull request Nov 13, 2024
Closed
@aerorahul aerorahul added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Nov 13, 2024
aerorahul
aerorahul previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Nov 13, 2024
@emcbot emcbot added CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels Nov 13, 2024
@emcbot
Copy link

emcbot commented Nov 13, 2024

Experiment C48_ATM FAILED on Hercules in Build# 1 with error logs:

/work2/noaa/global/CI/HERCULES/3097/RUNTESTS/COMROOT/C48_ATM_a245732c/logs/2021032312/gfs_stage_ic.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Nov 13, 2024
@emcbot
Copy link

emcbot commented Nov 13, 2024

Experiment C48_ATM FAILED on Hercules in Build# 1 in
/work2/noaa/global/CI/HERCULES/3097/RUNTESTS/EXPDIR/C48_ATM_a245732c

@emcbot
Copy link

emcbot commented Nov 13, 2024

Experiment C48_S2SW FAILED on Hercules in Build# 1 with error logs:

/work2/noaa/global/CI/HERCULES/3097/RUNTESTS/COMROOT/C48_S2SW_a245732c/logs/2021032312/gfs_stage_ic.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link

emcbot commented Nov 13, 2024

Experiment C48_S2SW FAILED on Hercules in Build# 1 in
/work2/noaa/global/CI/HERCULES/3097/RUNTESTS/EXPDIR/C48_S2SW_a245732c

@emcbot emcbot removed the CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed label Nov 14, 2024
@emcbot emcbot added the CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed label Nov 14, 2024
@emcbot
Copy link

emcbot commented Nov 14, 2024

CI Failed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3097


Experiment C48_ATM_a245732c Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Wed Nov 13 17:04:11 CST 2024
Experiment C48_ATM_a245732c Terminated: *FAIL*
Error logs:
/work2/noaa/global/CI/HERCULES/3097/RUNTESTS/COMROOT/C48_ATM_a245732c/logs/2021032312/gfs_stage_ic.log
Experiment C48_S2SW_a245732c Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Wed Nov 13 17:10:16 CST 2024
Experiment C48_S2SW_a245732c Terminated: *FAIL*
Error logs:
/work2/noaa/global/CI/HERCULES/3097/RUNTESTS/COMROOT/C48_S2SW_a245732c/logs/2021032312/gfs_stage_ic.log
Experiment C96_S2SWA_gefs_replay_ics_a245732c Completed 1 Cycles: *SUCCESS* at Wed Nov 13 18:17:38 CST 2024
Experiment C96_atm3DVar_a245732c Completed 3 Cycles: *SUCCESS* at Wed Nov 13 19:54:42 CST 2024
Experiment C96C48_hybatmDA_a245732c Completed 3 Cycles: *SUCCESS* at Wed Nov 13 19:54:42 CST 2024
Experiment C48_S2SWA_gefs_a245732c Completed 1 Cycles: *SUCCESS* at Wed Nov 13 20:13:12 CST 2024

@CatherineThomas-NOAA CatherineThomas-NOAA mentioned this pull request Nov 14, 2024
Merged
6 tasks
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the blocked Issue is currently being blocked by another issue label Nov 15, 2024
RussTreadon-NOAA
RussTreadon-NOAA approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

aerorahul
aerorahul approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reverting the IC dates.
approved and will commence CI

@aerorahul aerorahul added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules and removed blocked Issue is currently being blocked by another issue CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Nov 15, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Nov 15, 2024
@emcbot
Copy link

emcbot commented Nov 15, 2024

CI Passed on Hercules in Build# 2
Built and ran in directory /work2/noaa/global/CI/HERCULES/3097


Experiment C48_ATM_67139d1a Completed 2 Cycles: *SUCCESS* at Fri Nov 15 10:41:30 CST 2024
Experiment C96_S2SWA_gefs_replay_ics_67139d1a Completed 1 Cycles: *SUCCESS* at Fri Nov 15 11:29:59 CST 2024
Experiment C48_S2SWA_gefs_67139d1a Completed 1 Cycles: *SUCCESS* at Fri Nov 15 14:14:51 CST 2024
Experiment C48_S2SW_67139d1a Completed 2 Cycles: *SUCCESS* at Fri Nov 15 14:19:37 CST 2024
Experiment C96_atm3DVar_67139d1a Completed 3 Cycles: *SUCCESS* at Fri Nov 15 15:32:22 CST 2024
Experiment C96C48_hybatmDA_67139d1a Completed 3 Cycles: *SUCCESS* at Fri Nov 15 15:38:50 CST 2024

@aerorahul aerorahul merged commit 3209bea into NOAA-EMC:develop Nov 15, 2024
10 of 11 checks passed
@CatherineThomas-NOAA CatherineThomas-NOAA deleted the feature/taper branch November 16, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA left review comments

Assignees
No one assigned
Labels
CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable tapering of atm ensemble spread at the model top
6 participants
@CatherineThomas-NOAA @RussTreadon-NOAA @emcbot @CoryMartin-NOAA @aerorahul @WalterKolczynski-NOAA