-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update global_enkf ctest for tapering of perturbations (#806) #807
Update global_enkf ctest for tapering of perturbations (#806) #807
Conversation
Hera ctest results
The
A rerun of the hafs test succeeded:
I will run the tests on additional machines tomorrow. |
@CatherineThomas-NOAA , who would you like to request two peer reviews from? |
@TravisElless-NOAA and @AndrewEichmann-NOAA: Would you be available to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Hera global_enkf
passed. Did we confirm
enkf.x
ran withtaperanalperts=.true.
- perturbations are indeed tapered
From the Hera ctest global_enkf_hiproc_updat stdout:
For the effect of tapering itself, I usually use the spread netcdf files produced from the epos step. Using the data from the ctest, I tried to look at the differences between the increments of a couple members, but it's hard to tell if there's an effect there. The tapering does not set spread to zero at the model top, just reduces it. For previous comparisons when |
Dogwood ctests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here correctly reflect changes made in the associated GW PR
This PR can be scheduled for merger once we get a second approval from a peer reviewer. @AndrewEichmann-NOAA , can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable
Description
The global_enkf ctest needs to be updated to include a change to the configuration of GFSv17. The upper layer ensemble spread is too large, so we are enabling a new feature in the EnKF to reduce the spread as part of the ensemble analysis. This feature was previously included in the GSI EnKF source code (Issue #728) and being turned on in the global-workflow through NOAA-EMC/global-workflow#3097. The g-w PR is not required to exercise this PR.
Fixes #806
Type of change
How Has This Been Tested?
The taperanalperts feature was tested in an ATM-only C384/C192 cycling parallel on Hera. The GSI regression tests were run on Hera (results in following comment).
Checklist