Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPINEDEM-3059 Deploy karate sandbox #1062

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Commits on Oct 28, 2024

  1. The API allows the request id to contain uppercase A through F inclus…

    …ive; the sandbox should also allow this.
    davidhamill1-nhs committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    29a60ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ace90d2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3094ba4 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Begin move towards using the Karate sandbox: have the makefile no lon…

    …ger call the node.js app for the sandbox.
    davidhamill1-nhs committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8781889 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7107a72 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f11eefc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0adc50f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    886af0a View commit details
    Browse the repository at this point in the history
  6. Revert "Remove unnecessary sandbox start up"

    This reverts commit 886af0a.
    davidhamill1-nhs committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9677a92 View commit details
    Browse the repository at this point in the history
  7. Revert "With node.js app revoed, make file needs to run the Karate ap…

    …plication."
    
    This reverts commit 0adc50f.
    davidhamill1-nhs committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    90d5c68 View commit details
    Browse the repository at this point in the history
  8. Revert "Remove depracated node.js sandox."

    This reverts commit f11eefc.
    davidhamill1-nhs committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    42917c8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b875719 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    744d000 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    bc051b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    125fed4 View commit details
    Browse the repository at this point in the history
  2. Begin to improve file structure for sandbox and karate tests

    So as not to duplicate or overcomplicate the file structure, we will keep the sandbox/mock application source code in the karate tests directory, but have a sandbox directory that will contain the Dockerfile required to build the mock/sandbox application.
    davidhamill1-nhs committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3475406 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1817614 View commit details
    Browse the repository at this point in the history
  4. To prevent wasted resources/time, stop and fail the tests step if 10 …

    …tests fail. This would indicate that something more fundamental is wrong than just some funcitonal error/bug.
    davidhamill1-nhs committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d1393ea View commit details
    Browse the repository at this point in the history
  5. The Karate sandbox _currently_ requires an auth header, where the pre…

    …vious node.js sandbox did not.
    davidhamill1-nhs committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    63cd686 View commit details
    Browse the repository at this point in the history
  6. This scrip tis no longer necessary as the sandbox directory no long…

    …er contains anything other than the Dockerfile (which points to the Karate mock application) - ie there is nothing to lint in the `sandbox` directory.
    davidhamill1-nhs committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    686c6cc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5139e7b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cc4a2c4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0f9bfa1 View commit details
    Browse the repository at this point in the history
  10. Remove supporting Karate mock/sandbox files from sandbox directory.

    During development, the karate sandbox source code was duplicated into the `sandbox` directory. It is no longer required as `sandbox/Dockerfile` now points to the original karate-tests Karate mock/sandbox source code.
    davidhamill1-nhs committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1fa2946 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3e7f9bf View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    15097e0 View commit details
    Browse the repository at this point in the history
  2. Correct lint issues.

    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    85cec7b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08d69f5 View commit details
    Browse the repository at this point in the history
  4. Some query parameters can take multiple values. These parameters are …

    …not strings, but arrays, and have to be handled as suhc.
    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    26650ec View commit details
    Browse the repository at this point in the history
  5. Revert "Some query parameters can take multiple values. These paramet…

    …ers are not strings, but arrays, and have to be handled as suhc."
    
    This reverts commit 26650ec.
    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7fc346b View commit details
    Browse the repository at this point in the history
  6. Some query parameters can take multiple values. These parameters are …

    …not strings, but arrays, and have to be handled as such.
    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    22ad41a View commit details
    Browse the repository at this point in the history
  7. When queyr paramters are swent that are not supported, eg foo, then a…

    …n "additional properties" error message should be returned, not a "missing value" error.
    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a950901 View commit details
    Browse the repository at this point in the history
  8. The compound name test scenarios requires/expects two given names to …

    …be provided, so have to pass the whole array in rather than jsut the first element.
    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1516451 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e11b971 View commit details
    Browse the repository at this point in the history
  10. Tidying up.

    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8d1688e View commit details
    Browse the repository at this point in the history
  11. Further corrections made to pytest logic and scenarios to expected th…

    …e correct responses from the Karate sandbox.
    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    599ed21 View commit details
    Browse the repository at this point in the history
  12. The first brithdate query parameter is required to detemine if this m…

    …eeds the "compound name search" pytest test scenario.
    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0e22d7b View commit details
    Browse the repository at this point in the history
  13. Given the public docs, sending an invalid date format in teh brithdat…

    …e field is an INVALID_VALUE resposne, not INVALID_SEARCH_DATA resposne. Updating pytest test expected response accordingly.;
    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    91274d8 View commit details
    Browse the repository at this point in the history
  14. Tidying up.

    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9d3fa22 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7f0b837 View commit details
    Browse the repository at this point in the history
  16. Fix linting issues.

    davidhamill1-nhs committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a2854ea View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6de7552 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    07bdbac View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Swap out sandbox testsuite.

    We should run the Karate sandbox tests against the Karate sandbox application deployed.
    davidhamill1-nhs committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c51d3da View commit details
    Browse the repository at this point in the history
  2. Revert "Swap out sandbox testsuite."

    This reverts commit c51d3da.
    davidhamill1-nhs committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a4a4fa3 View commit details
    Browse the repository at this point in the history
  3. Swap out sandbox testsuite.

    We should run the Karate sandbox tests against the Karate sandbox application deployed.
    davidhamill1-nhs committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a7ac84e View commit details
    Browse the repository at this point in the history
  4. Use separate test classes/runners for local and deployed sandbox.

    Once all is working in the pipeline, this should be undone, so that we keep the local and the deployed sandbox tests as one class.
    davidhamill1-nhs committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    4d3ac9c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5313d03 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bae6a2a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0b031f9 View commit details
    Browse the repository at this point in the history
  8. By giving Karate test class/runner a specific environment, we can ens…

    …ure the correct NHS number/Patient is used during testing.
    davidhamill1-nhs committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3fe4d85 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    324b086 View commit details
    Browse the repository at this point in the history
  10. Revert changes to Karate sandbox application that were made to accoma…

    …date the pytest sandbox testsuite.
    davidhamill1-nhs committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    549aa80 View commit details
    Browse the repository at this point in the history