Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPINEDEM-3059 Deploy karate sandbox #1062

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

davidhamill1-nhs
Copy link
Contributor

Summary

  • Update Karate to bring it inline with node.js sandbox app
  • Deploy sandbox for external use

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

So as not to duplicate or overcomplicate the file structure, we will keep the sandbox/mock application source code in the karate tests directory, but have a sandbox directory that will contain the Dockerfile required to build the mock/sandbox application.
Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

…tests fail. This would indicate that something more fundamental is wrong than just some funcitonal error/bug.
…eeds the "compound name search" pytest test scenario.
…e field is an INVALID_VALUE resposne, not INVALID_SEARCH_DATA resposne. Updating pytest test expected response accordingly.;
Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

We should run the Karate sandbox tests against the Karate sandbox application deployed.
Copy link

github-actions bot commented Nov 4, 2024

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

We should run the Karate sandbox tests against the Karate sandbox application deployed.
Copy link

github-actions bot commented Nov 4, 2024

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Once all is working in the pipeline, this should be undone, so that we keep the local and the deployed sandbox tests as one class.
Copy link

github-actions bot commented Nov 4, 2024

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

github-actions bot commented Nov 4, 2024

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

github-actions bot commented Nov 4, 2024

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

…ure the correct NHS number/Patient is used during testing.
Copy link

github-actions bot commented Nov 4, 2024

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

github-actions bot commented Nov 4, 2024

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Copy link

github-actions bot commented Nov 4, 2024

This branch is working on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

SPINEDEM-3059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant