Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sui-http: Introduce crate to standardize how we start http services #20750

Merged
merged 12 commits into from
Jan 6, 2025
Merged

sui-http: Introduce crate to standardize how we start http services #20750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c108798
network: add vendored version of GrpcTimeout
bmwill Dec 31, 2024
eb9f8e1
consensus: add support for gRPC timeouts
bmwill Dec 31, 2024
489ab9b
network: impl ToSocketAddrs for Multiaddr
bmwill Dec 31, 2024
3621b04
sui-http: introduce crate for building http services
bmwill Jan 2, 2025
2e3806f
sui-http: add support for insecure connections when a tls config is p…
bmwill Dec 31, 2024
acd99ca
sui-http: add a graceful shutdown grace period
bmwill Dec 31, 2024
c1ce38b
sui-http: add support for waiting for server shutdown
bmwill Jan 2, 2025
9ad39e7
sui-http: provide peer certs via a PeerCertificates type
bmwill Jan 2, 2025
c97668f
consensus: use sui-http for running the gRPC http server
bmwill Jan 2, 2025
b19b7af
network: use sui-http for running gRPC http server
bmwill Jan 2, 2025
a8ffd5a
sui-node: use sui-http for rpc http service
bmwill Jan 2, 2025
7fe43ef
tls: configure validator interface to not require client auth
bmwill Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ members = [
"crates/sui-graphql-rpc",
"crates/sui-graphql-rpc-client",
"crates/sui-graphql-rpc-headers",
"crates/sui-http",
"crates/sui-indexer",
"crates/sui-indexer-alt",
"crates/sui-indexer-alt-framework",
Expand Down Expand Up @@ -641,6 +642,7 @@ sui-graphql-rpc = { path = "crates/sui-graphql-rpc" }
sui-graphql-rpc-client = { path = "crates/sui-graphql-rpc-client" }
sui-graphql-rpc-headers = { path = "crates/sui-graphql-rpc-headers" }
sui-genesis-builder = { path = "crates/sui-genesis-builder" }
sui-http = { path = "crates/sui-http" }
sui-indexer = { path = "crates/sui-indexer" }
sui-indexer-alt-framework = { path = "crates/sui-indexer-alt-framework" }
sui-indexer-alt-jsonrpc = { path = "crates/sui-indexer-alt-jsonrpc" }
Expand Down
5 changes: 1 addition & 4 deletions consensus/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ enum_dispatch.workspace = true
fastcrypto.workspace = true
futures.workspace = true
http.workspace = true
hyper.workspace = true
hyper-util.workspace = true
hyper-rustls.workspace = true
itertools.workspace = true
quinn-proto.workspace = true
mockall.workspace = true
Expand All @@ -49,7 +46,6 @@ sui-tls.workspace = true
tap.workspace = true
thiserror.workspace = true
tokio.workspace = true
tokio-rustls.workspace = true
tokio-stream.workspace = true
tokio-util.workspace = true
tonic.workspace = true
Expand All @@ -58,6 +54,7 @@ tower-http.workspace = true
tracing.workspace = true
typed-store.workspace = true
tonic-rustls.workspace = true
sui-http.workspace = true

[dev-dependencies]
rstest.workspace = true
Expand Down
3 changes: 0 additions & 3 deletions consensus/core/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,6 @@ pub(crate) enum ConsensusError {
#[error("Failed to connect as client: {0:?}")]
NetworkClientConnection(String),

#[error("Failed to connect as server: {0:?}")]
NetworkServerConnection(String),

#[error("Failed to send request: {0:?}")]
NetworkRequest(String),

Expand Down
Loading
Loading