sui-http: Introduce crate to standardize how we start http services #20750
+1,911
−631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Add a vendored version of the tonic GrpcTimeout layer in order to support the gRPC deadline/timeout spec when serving gRPC services not using tonic's `transport::server` module.
Given we're not leveraging tonic's `transport::server` module for serving the consensus gRPC interface we don't have out-of-the-box support for gRPC timeouts configured via the `grpc-timeout` header. This patch adds this support by using the vendored GrpcTimeout service from `mysten-network`.
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Introduce the `sui-http` crate which is intended to be a standard way of building and running http services in sui.
…rovided Add support for allowing insecure connections when a tls config is provided. Normally when a server is started with a TLS config, it is required that all clients perform a TLS handshake. This patch optionally allows a client to skip the TLS handshake by simply starting http/1.1 or http/2 communication. This is intended to be a temporary feature while the sui validator interface is being migrated to support TLS secured connections.
Add a grace period of 1 second to http servers when shutting down after which the server will forcefully terminate all existing connections.
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
changed the title
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Configure the validator interface to not require client authentication as well as enforce that TLS1.3 is used.
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce the
sui-httpcrate in order to begin to standardize how we start http services in sui.Today we have a few different ways for setting up http services:
tonic::transport::servermodule for starting the service.axum::servemethod for other places (metrics servers, as well as the fullnode RPC service)This introduces a new way to start http services by taking learnings from tonic, axum, consensus's manual setup, as well as our p2p network
anemo. This new http server still leverages hyper under the hood, and leverages thetower::Servicetrait for request handlers, but provides us with more flexibility to be able to:With this standard we should in the future also be able to better standardize on how tracing spans and metrics are tracked and collected for all of these services.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.