Domain resample #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-marqh
force-pushed
the
domain_resample
branch
3 times, most recently
from
e287efd to
02572ed
Compare
Merged
mo-marqh
force-pushed
the
domain_resample
branch
from
02572ed to
f0eda8d
Compare
svadams
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
I've looked through all the code changes and they look fine to me. We've discussed offline how to accommodate different types of test, but that needs to wait until we have a suitable test case. I have run the read_axis_resample and read_domain_resample examples on the Linux VDI desktop and they all work as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, numerical results under investigation
this builds on the work of #1 and is a follow up to that