Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XIOS example resample #1

Merged
merged 6 commits into from
Feb 26, 2024
Merged

XIOS example resample #1

merged 6 commits into from
Feb 26, 2024

Conversation

mo-marqh
Copy link
Member

@mo-marqh mo-marqh commented Feb 7, 2024 •
edited
Loading

this is a code example of resample along a single axis, using an input netcdf file to set the conditions for the resample operation

depends upon #4

@mo-marqh mo-marqh mentioned this pull request Feb 7, 2024
Merged
@mo-marqh mo-marqh force-pushed the xios-example-resample branch 5 times, most recently from 475517a to 111d43e Compare February 14, 2024 12:56
@mo-marqh mo-marqh force-pushed the xios-example-resample branch from cfeaf13 to 5c1d325 Compare February 14, 2024 15:32
mo-nabilbrice
mo-nabilbrice approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mo-nabilbrice mo-nabilbrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great approach to enable adding new test cases through adding a .cdl file.

There were a couple of things that I'd like to suggest from a maintainability angle but they aren't necessary, so I'll mark this as approved.

xios_examples/read_axis_resample/Makefile Outdated Show resolved Hide resolved
xios_examples/read_axis_resample/test_resample_cases.py Outdated Show resolved Hide resolved
@mo-marqh
Copy link
Member Author

i've added a commit which aims to resolve both comments, thank you @mo-nabilbrice

@mo-nabilbrice
Copy link
Contributor

i've added a commit which aims to resolve both comments, thank you @mo-nabilbrice

Thanks! This all looks good to me!

@mo-nabilbrice mo-nabilbrice merged commit ed72edf into MetOffice:main Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo-nabilbrice mo-nabilbrice mo-nabilbrice approved these changes

Assignees

@mo-nabilbrice mo-nabilbrice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mo-marqh @mo-nabilbrice