-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: network policies (1.9.0) #49
Conversation
It's currently failing test:
This happens because of how helm upgrades charts. To fix it you need to check if This issue only happens on upgrades, not fresh installs. |
Patch pushed + aligned with master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to add a couple changes too so it's bundled in the same release.
- Ingress | ||
- Egress | ||
ingress: | ||
{{- if .Values.networkPolicy.allowIngress }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit weird way to structure it, but I think it's ok for now. We can always accept a PR to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I copy paste from my PR for varnish, varnish/helm-varnish-cache#24
It's not really clean but it allow to unblock when we use strict mode on cni :)
TODO: add a default schema that took into account the port & probably a matchexpressions based on ns or pod selector
Thank you!
Descriptive description goes here.
Tasks:
Chart.yaml
CHANGELOG.md
helm-docs
Fixes: #50