Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding podAnnotations for tests #50 #51

Closed
wants to merge 3 commits into from
Closed

Conversation

anthosz
Copy link
Contributor

@anthosz anthosz commented Oct 25, 2024

Descriptive description goes here.

Tasks:

@anthosz
Copy link
Contributor Author

anthosz commented Oct 25, 2024

Related to #50

@MaikuMori
Copy link
Owner

I think this doesn't necessarily do what you want. If it's the same annotation, and you ignore checks for test pod, you're now also ignoring checks on Gotenberg pod which maybe are valuable.

So I see 2 options:

  • Add separate values entry
  • Add kube-score annotations to test pod in the chart itself.

I think the 1st option is more universal.

@MaikuMori
Copy link
Owner

Combined with #49

@MaikuMori MaikuMori closed this Oct 26, 2024
@anthosz
Copy link
Contributor Author

anthosz commented Oct 26, 2024

Thank you @MaikuMori !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants