Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults: add controlcenter and other options #1163

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

LucasMendesl
Copy link
Contributor

Adding support to control center API

modules/system/defaults-write.nix Outdated Show resolved Hide resolved
modules/system/defaults/controlcenter.nix Outdated Show resolved Hide resolved
modules/system/defaults/controlcenter.nix Outdated Show resolved Hide resolved
modules/system/defaults/controlcenter.nix Outdated Show resolved Hide resolved
@Enzime
Copy link
Collaborator

Enzime commented Nov 11, 2024

You'll need to add your new module file to modules/module-list.nix

@Enzime
Copy link
Collaborator

Enzime commented Nov 11, 2024

You'll also need to add controlcenter to here: https://github.com/LnL7/nix-darwin/pull/1163/files#diff-b44750cda15d1291f935ca5053d5aa14c6b1492c38c8bd9c078a0b2d752eaad6L72

And you'll need to update tests/fixtures/system-defaults-write/activate-user.txt

@LucasMendesl
Copy link
Contributor Author

@Enzime, fixed issues and including #1107

@LucasMendesl
Copy link
Contributor Author

You'll need to add your new module file to modules/module-list.nix

Done

@Enzime Enzime changed the title Feature/controlcenter defaults: add controlcenter and other options Nov 12, 2024
@Enzime
Copy link
Collaborator

Enzime commented Nov 12, 2024

Can you squash it into 2 commits? One for the controlcenter changes and another one for the non-controlcenter changes

@LucasMendesl
Copy link
Contributor Author

Can you squash it into 2 commits? One for the controlcenter changes and another one for the non-controlcenter changes

@Enzime, Done 😄

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM

modules/system/defaults-write.nix Outdated Show resolved Hide resolved
@@ -17,6 +17,7 @@ let
SoftwareUpdate = defaultsToList "/Library/Preferences/com.apple.SoftwareUpdate" cfg.SoftwareUpdate;

# userDefaults
controlcenter = defaultsToList "~/Library/Preferences/ByHost/com.apple.controlcenter" cfg.controlcenter;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move it to the bottom here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution

@Enzime Enzime merged commit e30d226 into LnL7:master Nov 12, 2024
6 checks passed
@Enzime Enzime mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants