Updated defaults #1107
Closed
Updated defaults #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craz1k0ek
commented
Oct 17, 2024
Craz1k0ek
commented
- Added some more defaults settings
Craz1k0ek
force-pushed
the
update/defaults
branch
from
eb73685
to
1eecf7c
Compare
Enzime
requested changes
Nov 5, 2024
Samasaur1
reviewed
Nov 5, 2024
@Enzime Not sure what I need to update to make the test succeed. Error message is incomprehensible to me |
|
Can you rebase your PR on master? It should fix the failing test, and then can you add some more tests to test the new options you added? |
Craz1k0ek
force-pushed
the
update/defaults
branch
from
1eecf7c
to
fe19674
Compare
* Added some more defaults settings
Craz1k0ek
force-pushed
the
update/defaults
branch
from
fe19674
to
9b895f1
Compare
* Added several test cases to the new defaults
|
@Enzime not sure why the tests are failing. Anything wrong in my syntax? The error message is so poor, I can't make anything of it |
LucasMendesl
added a commit
to LucasMendesl/nix-darwin
that referenced
this pull request
Nov 12, 2024
LucasMendesl
added a commit
to LucasMendesl/nix-darwin
that referenced
this pull request
Nov 12, 2024
LucasMendesl
added a commit
to LucasMendesl/nix-darwin
that referenced
this pull request
Nov 12, 2024
|
This has been superseded by #1163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.