Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed fix and Metadata addition to sacc #55

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

arthurmloureiro
Copy link
Contributor

@arthurmloureiro arthurmloureiro commented Aug 6, 2024

Ensure the seed leads to reproducible shifts and adds metadata to the concealed sacc file

To Do

  • Add seed as a metadata to the saved sacc
  • Include more metadata to the sacc file
  • copy the original metadata to the sacc file
  • test if the same seed yields the same shifts in different computers.
  • include unit test coverage for the new metadata lines

@arthurmloureiro arthurmloureiro added enhancement data-vector blinding Issues related to data-vector blinding SACC SACC file format related issues labels Aug 6, 2024
@arthurmloureiro arthurmloureiro self-assigned this Aug 6, 2024
@arthurmloureiro arthurmloureiro linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (ac8dff5) to head (53ba5af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   96.73%   98.44%   +1.70%     
==========================================
  Files           6        6              
  Lines         184      193       +9     
==========================================
+ Hits          178      190      +12     
+ Misses          6        3       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurmloureiro arthurmloureiro merged commit bac7707 into main Aug 6, 2024
7 checks passed
@arthurmloureiro arthurmloureiro deleted the fix-seed_sacc branch August 6, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-vector blinding Issues related to data-vector blinding enhancement SACC SACC file format related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seed for consistency
1 participant