Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed for consistency #45

Closed
m-aguena opened this issue Jul 11, 2024 · 5 comments · Fixed by #55
Closed

Seed for consistency #45

m-aguena opened this issue Jul 11, 2024 · 5 comments · Fixed by #55
Assignees
Labels
data-vector blinding Issues related to data-vector blinding enhancement SACC SACC file format related issues

Comments

@m-aguena
Copy link

If we ensure that a given seed always results in the same set of cosmological parameters, it can be used to blind different probes individually. This will remove the necessity of generating the data vectors of all your probes at the same time.

IMPORTANT reminder: save the seed on the blinded data vector file!

@arthurmloureiro arthurmloureiro self-assigned this Jul 11, 2024
@arthurmloureiro arthurmloureiro added enhancement data-vector blinding Issues related to data-vector blinding SACC SACC file format related issues labels Jul 11, 2024
@arthurmloureiro arthurmloureiro added this to the Smokescreen v1.0 milestone Jul 11, 2024
@arthurmloureiro arthurmloureiro pinned this issue Aug 6, 2024
@arthurmloureiro
Copy link
Contributor

I realised I was not keeping the original metadata in the blinded sacc!

This is now fixed :)

I also added a concealed = True metadata !

@arthurmloureiro arthurmloureiro linked a pull request Aug 6, 2024 that will close this issue
5 tasks
@arthurmloureiro
Copy link
Contributor

arthurmloureiro commented Aug 6, 2024

String seed: seed = "test"

Locally: Shifts: {'Omega_c': 0.25876948503900465, 'sigma8': 0.7726193034315977}
Sunrise: Shifts: {'Omega_c': 0.25876948503900465, 'sigma8': 0.7726193034315977}

Int Seed: 2112

Locally: Shifts: {'Omega_c': 0.21229098052498757, 'sigma8': 0.7142436174585977}
Sunrise: {'Omega_c': 0.21229098052498757, 'sigma8': 0.7142436174585977}

@arthurmloureiro
Copy link
Contributor

I also tested that if you give different number of parameters, the values are the same for the same parameters:

  • Locally (omega_c and sigma8): Shifts: {'Omega_c': 0.21229098052498757, 'sigma8': 0.7142436174585977}
  • Sunrise (only omega_c): Shifts: {'Omega_c': 0.21229098052498757}

@arthurmloureiro
Copy link
Contributor

Now, of course... if you invert or change the order of the required shift parameters, the shifts will be different:

  • Locally: Shifts: {'sigma8': 0.7001923251481939, 'Omega_c': 0.22084394106175506}
  • Sunrise (inverted order): Shifts: {'Omega_c': 0.21229098052498757, 'sigma8': 0.7142436174585977}

Maybe this can be avoided by looping over CCL dictionaries of cosmological parameters instead of looping over the shifts dictionary...

@arthurmloureiro
Copy link
Contributor

arthurmloureiro commented Aug 6, 2024

Now, of course... if you invert or change the order of the required shift parameters, the shifts will be different:

  • Locally: Shifts: {'sigma8': 0.7001923251481939, 'Omega_c': 0.22084394106175506}
  • Sunrise (inverted order): Shifts: {'Omega_c': 0.21229098052498757, 'sigma8': 0.7142436174585977}

Maybe this can be avoided by looping over CCL dictionaries of cosmological parameters instead of looping over the shifts dictionary...

yeah, that worked! Fixed by 53ba5af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-vector blinding Issues related to data-vector blinding enhancement SACC SACC file format related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants