Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump libcurl to 8.4.0 #594

Merged
merged 1 commit into from
Oct 28, 2023
Merged

bump libcurl to 8.4.0 #594

merged 1 commit into from
Oct 28, 2023

Conversation

DeckerSU
Copy link

@DeckerSU DeckerSU requested review from ca333 and Alrighttt October 19, 2023 04:38
@DeckerSU
Copy link
Author

MacOS build fail here is not related. not mach-o or llvm bitcode file error is rust + XCode version related. XCode 14 broke rustc 1.53 and older. We have to update to at least rustc 1.54 or downgrade CI to XCode 13 or older (for example runs-on: macos-11, instead of runs-on: macos-latest).

@DeckerSU DeckerSU mentioned this pull request Oct 24, 2023
Merged
Alrighttt
Alrighttt approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@Alrighttt Alrighttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeckerSU DeckerSU merged commit cc237be into KomodoPlatform:dev Oct 28, 2023
7 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alrighttt Alrighttt Alrighttt approved these changes

@ca333 ca333 ca333 approved these changes

Assignees
No one assigned
Labels
under test/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeckerSU @ca333 @Alrighttt