-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update rust to 1.69.0 #595
Conversation
the cross-compilation process in the rust komodo recipe differs slightly from the current native_rust recipe used in Zcash. therefore, we have commented out all invocations of the "update_stdlib_hash" function until the komodo rust recipe is updated.
todo: we still need rework rust integration, crates build, etc.
Just wanted to share I have been using 1.66 on my mac for a few weeks without any issue. Will do further testing with 1.69.0. I am curious why you choose 1.69.0. |
I chose version By the way, the issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please provide a comment on the purpose and usage of this script
This pull request updates Rust to version 1.69.0. However, we still need to rework the Rust integration, build the crates, and address other related issues. Additionally, this update is expected to resolve the known "not mach-o or llvm bitcode file" issue on MacOS native builds, as described here: #594 (comment). Please refrain from merging this pull request until all tests, including a sync from scratch and sapling crypto, have been completed.
Furthermore, we have the opportunity to address the warnings that arise during the build of Rust crates.