Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonRpcConnection: don't write any data on shutdown #10216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

JsonRpcConnection: don't write any data on shutdown #10216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15cd130
JsonRpcConnection: don't write any data on shutdown
Al2Klimov Nov 7, 2024
3112e1f
JsonRpcConnection: don't flush any data on shutdown
Al2Klimov Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/remote/jsonrpcconnection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,21 @@ void JsonRpcConnection::WriteOutgoingMessages(boost::asio::yield_context yc)
if (!queue.empty()) {
try {
for (auto& message : queue) {
if (m_ShuttingDown) {
return;
}

size_t bytesSent = JsonRpc::SendRawMessage(m_Stream, message, yc);

if (m_Endpoint) {
m_Endpoint->AddMessageSent(bytesSent);
}
}

if (m_ShuttingDown) {
return;
}

m_Stream->async_flush(yc);
} catch (const std::exception& ex) {
Log(m_ShuttingDown ? LogDebug : LogWarning, "JsonRpcConnection")
Expand Down
Loading