Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonRpcConnection: don't write any data on shutdown #10216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

JsonRpcConnection: don't write any data on shutdown #10216

wants to merge 2 commits into from

Commits on Nov 7, 2024

  1. JsonRpcConnection: don't write any data on shutdown 

    In fact, this is already done for the outer loop (for each bulk), just not yet for the inner one (for each message of a bulk). So once the remote signals EOF, don't try to get things done until write error (which can't be associated with a particular message anyway, due to buffering), but just let the peer go.
    @Al2Klimov
    Al2Klimov committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    15cd130 View commit details
    Browse the repository at this point in the history

  2. JsonRpcConnection: don't flush any data on shutdown 

    In fact, this is already done for both loops (for each bulk and for each message of it). So once the remote signals EOF, don't try to get things done until write error (which can't be associated with a particular message anyway, due to buffering), but just let the peer go.
    @Al2Klimov
    Al2Klimov committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3112e1f View commit details
    Browse the repository at this point in the history