icinga2: Common Muted Event for Acknowledgements w/o Comments during Catch-Up #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
reviewed
Jul 19, 2024
julianbrost
reviewed
Jul 19, 2024
oxzi
force-pushed
the
ack-misses-comment-i245
branch
from
a4afb82
to
b3a137e
Compare
oxzi
changed the title
yhabteab
reviewed
Jul 22, 2024
…Catch-Up When creating an acknowledgement in Icinga Web, a comment is also added. It is possible, however, to later delete the comment while keeping the object acknowledged. Deleting acknowledgement comments was not an expected behavior, requiring the presence of an associated comment for each acknowledgement. Otherwise, the catch-up-phase would not succeed. Unfortunately, there is no way to later add an author to an acknowledgement unless a matching comment exists. Thus, the catch-up-phase will now generalize this acknowledgement into a common muted event, missing the details available in the comment. Closes #245.
oxzi
force-pushed
the
ack-misses-comment-i245
branch
from
b3a137e
to
df0f8ac
Compare
julianbrost
approved these changes
Jul 22, 2024
yhabteab
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an acknowledgement in Icinga Web, a comment is also added. It is possible, however, to later delete the comment while keeping the object acknowledged.
Deleting acknowledgement comments was not an expected behavior, requiring the presence of an associated comment for each acknowledgement. Otherwise, the catch-up-phase would not succeed.
Unfortunately, there is no way to later add an author to an acknowledgement unless a matching comment exists. Thus, the catch-up-phase will now generalize this acknowledgement into a common muted event, missing the details available in the comment.
Closes #245.